This repository has been archived by the owner on Jul 9, 2024. It is now read-only.
Add parameter to factory method for setting handler options #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
suggested changes
Apr 23, 2024
There was a problem hiding this comment.
Thanks for the contribution!
Depending on when #245 is merged, this PR will need to contain a version bump and a changelog entry.
Added a comment.
Also, did you start working on unit tests for that? Did you run into any issues with those?
Added tests to the PR. As mentioned in #233 , I cannot run the tests locally unless I remove the analyzer reference from the .csproj file. |
This comment was marked as outdated.
This comment was marked as outdated.
baywet
suggested changes
Apr 24, 2024
Microsoft.Kiota.Http.HttpClientLibrary.Tests/KiotaClientFactoryTests.cs
Outdated
Show resolved
Hide resolved
|
No need to expedite. Thanks tho. |
|
@pschaeflein by expedite I meant "we don't want to have to open another PR just for the version bump because we're lazy" 🤣 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
baywet
reviewed
May 21, 2024
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
baywet
approved these changes
May 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #233